Opened 15 years ago

Closed 11 years ago

Last modified 5 years ago

#1982 defect closed fixed (fixed)

twisted.python.log.DefaultObserver ignores `why' argument of event dictionary

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: core Keywords: easy
Cc: Andy Ruse Branch: branches/defaultObserver-why-1982
branch-diff, diff-cov, branch-cov, buildbot
Author: cyli

Description

This is somewhat confusing, since it changes what information is available for debugging errors based on whether DefaultObserver or FileLogObserver is being used.

Attachments (1)

1982.patch (1.9 KB) - added by Andy Ruse 11 years ago.
Patch to resolve #1982

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by <automation>

Owner: Glyph deleted

comment:2 Changed 11 years ago by Jean-Paul Calderone

Keywords: easy added

comment:3 Changed 11 years ago by Jean-Paul Calderone

Summary: twisted.python.log.DefaultObserver ignores `msg' argument of event dictionarytwisted.python.log.DefaultObserver ignores `why' argument of event dictionary

comment:4 Changed 11 years ago by Andy Ruse

Cc: Andy Ruse added
Owner: set to Andy Ruse
Status: newassigned

Changed 11 years ago by Andy Ruse

Attachment: 1982.patch added

Patch to resolve #1982

comment:5 Changed 11 years ago by Andy Ruse

Keywords: review added
Owner: Andy Ruse deleted
Status: assignednew

comment:6 Changed 11 years ago by Ying Li

Author: cyli
Branch: branches/defaultObserver-why-1982

(In [31021]) Branching to 'defaultObserver-why-1982'

comment:7 Changed 11 years ago by Ying Li

(In [31024]) Applying aruse's patch

refs #1982

comment:8 Changed 11 years ago by Ying Li

Tests seem to pass, except for an unrelated epoll bug. Merging.

comment:9 Changed 11 years ago by Ying Li

Thanks for working on this aruse!

comment:10 Changed 11 years ago by Ying Li

(In [31030]) Added news file

refs #1982

comment:11 Changed 11 years ago by Ying Li

Resolution: fixed
Status: newclosed

(In [31031]) Merge defaultObserver-why-1982: Add 'why' argument to debugging error

Author: aruse Reviewer: cyli Fixes: #1982

Add 'why' argument of event dictionary to stderr output produced by twisted.python.log.DefaultObserver

comment:12 Changed 5 years ago by hawkowl

Keywords: review removed

[mass edit] Removing review from closed tickets.

Note: See TracTickets for help on using tickets.