Opened 16 years ago

Closed 16 years ago

#1973 defect closed fixed (fixed)

No IPathImportMapper adapter for imp.NullImporter

Reported by: Jean-Paul Calderone Owned by:
Priority: highest Milestone:
Component: core Keywords:
Cc: Branch:
Author:

Description

This totally breaks trial in Python 2.5 trunk@HEAD

Change History (10)

comment:1 Changed 16 years ago by Jean-Paul Calderone

(In [17769]) deal with NullImporter if we have to

refs #1973

comment:2 Changed 16 years ago by Glyph

Is there a final word on what Python is actually going to look like in the 2.5 release? I haven't been keeping up with python-dev but it looks like there was still some discussion.

comment:3 Changed 16 years ago by scmikes

Glyph,

I just installed python beta3 (Released on Aug 3), on the suse buildbot, and this behaviour is still in place.

comment:4 Changed 16 years ago by Jean-Paul Calderone

Keywords: review added
Owner: changed from Jean-Paul Calderone to radix
Priority: highhighest

python-dev says the current behavior is final. radix will review this for me.

comment:5 Changed 16 years ago by radix

Keywords: review removed
Owner: changed from radix to Jean-Paul Calderone

exarkun said this needs more work.

comment:6 Changed 16 years ago by Jean-Paul Calderone

Keywords: review added
Owner: changed from Jean-Paul Calderone to radix

Okay, really ready for review now.

comment:7 Changed 16 years ago by radix

Keywords: review removed
Owner: changed from radix to Jean-Paul Calderone

There aren't any unit tests

comment:8 Changed 16 years ago by radix

Ok, the test you added is satisfying. Go ahead and merge.

comment:9 Changed 16 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

Merge ignore-warnings-1972

Author: exarkun Reviewer: radix Fixes #1973

This changes the custom importer support in twisted.python.modules to deal with any unknown importer by passing the path straight through. This will not allow arbitrary importers to work correctly with twisted.python.modules, but it will prevent them from completely disrupting uses of it. Support for other importers should be added when they see more widespread use. Third parties can already support custom importers by registering adapters for IPathImportMapper.

comment:10 Changed 11 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.