#1955 defect new
a forgotten resetTimeout in twisted.protocols.postfix
|Reported by:||quakelee||Owned by:|
|Cc:||jesstess, Thijs Triemstra||Branch:||
branch-diff, diff-cov, branch-cov, buildbot
Description (last modified by )
I think after sent code to client, daemon should reset timeout. If data source is a big and slow object, getting and sending result to client may consume a lot of time, if you didn't reset the timer, the connection maybe lost before client reply to daemon.
old new 48 48 def sendCode(self, code, message=''): 49 49 "Send an SMTP-like code with a message." 50 50 self.sendLine('%3.3d %s' % (code, message or '')) 51 51 52 52 53 def lineReceived(self, line): 53 54 self.resetTimeout()