Opened 13 years ago

Closed 12 years ago

#1950 enhancement closed fixed (fixed)

PyUnitTestCase.id is redundant and should be removed

Reported by: Glyph Owned by:
Priority: normal Milestone:
Component: trial Keywords:
Cc: Branch:
Author:

Description

The reason it has not been is that it causes doctest tests to start failing, but perhaps doctest should have individual support.

Change History (8)

comment:1 Changed 13 years ago by Jonathan Lange

Status: newassigned

comment:2 Changed 12 years ago by Jonathan Lange

The branch for #2898 should make this easier to change.

comment:3 Changed 12 years ago by Jonathan Lange

Branch: branches/remove-id-1950

comment:4 Changed 12 years ago by Jonathan Lange

Branch: branches/remove-id-1950branches/remove-id-1950-2

comment:5 Changed 12 years ago by Jonathan Lange

(In [21788]) Hey look! I can delete this and the tests still pass.

Turns out that our re-implementation of id() for pyunit TestCase is totally unnecessary.

Refs #1950.

comment:6 Changed 12 years ago by Jonathan Lange

Branch: branches/remove-id-1950-2

Now being fixed in the branch for #2898.

comment:7 Changed 12 years ago by Jonathan Lange

Resolution: fixed
Status: assignedclosed

(In [21827]) Define ITestCase to be the interface that test frameworks expect of a test.

  • Author: jml
  • Reviewers: therve, exarkun
  • Fixes #2898

ITestCase is re-purposed to define what you can expect from a test object. We use this interface to adapt pyunit tests to things usable in Trial.

In the process we also clarify what's needed for compatibility with doctest and pyunit.

This branch also fixes #1950.

Refs #2739.

comment:8 Changed 9 years ago by <automation>

Owner: Jonathan Lange deleted
Note: See TracTickets for help on using tickets.