Opened 13 years ago

Closed 11 years ago

#1903 defect closed fixed (fixed)

Twisted doesn't reset timeout when getting POST data

Reported by: Moshe Zadka Owned by:
Priority: normal Milestone:
Component: web Keywords:
Cc: Branch: branches/request-body-timeout-1903-2
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

Symptom: a long POST will get timed out

Patch:

--- http.py-orig        2004-04-24 05:43:51.000000000 +0200
+++ http.py     2005-10-08 23:12:57.000000000 +0200
@@ -375,6 +375,7 @@
     handleStatus = handleHeader = handleEndHeaders = lambda *args: None
 
     def rawDataReceived(self, data):
+        self.resetTimeout()
         if self.length is not None:
             data, rest = data[:self.length], data[self.length:]
             self.length -= len(data)

Change History (7)

comment:1 Changed 11 years ago by Jean-Paul Calderone

author: exarkun
Branch: branches/request-body-timeout-1903

(In [24740]) Branching to 'request-body-timeout-1903'

comment:2 Changed 11 years ago by Jean-Paul Calderone

Keywords: review added
Owner: jknight deleted

Should be fixed

comment:3 Changed 11 years ago by therve

Keywords: review removed
Owner: set to Jean-Paul Calderone

Great, please merge.

comment:4 Changed 11 years ago by exarkun, exarkun

author: exarkunexarkun, exarkun
Branch: branches/request-body-timeout-1903branches/request-body-timeout-1903-2

(In [24818]) Branching to 'request-body-timeout-1903-2'

comment:5 Changed 11 years ago by Jean-Paul Calderone

author: exarkun, exarkunexarkun

A trivial conflict needed to be resolved, and now is in the -2 branch. As a bonus, I discovered a bug in my recent change to the author tracking code.

comment:6 Changed 11 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [24821]) Merge request-body-timeout-1903-2

Author: exarkun Reviewer: therve Fixes: #1903

Reset the idle timeout in the HTTP server whenever data from the request body is received. Since previously request body data did not cause the timeout to reset, if a client was making progress on sending a request body it might still have been disconnected due to the timeout.

comment:7 Changed 9 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.