Opened 17 years ago

Last modified 17 years ago

#190 defect closed fixed (fixed)

Small bug in web.py When cookie values contain the charachter = an execption is thrown

Reported by: Ben Owned by:
Priority: high Milestone:
Component: conch Keywords:
Cc: radix, Ben Branch:
Author:

Description


Attachments (1)

patch_request.diff-u (1.4 KB) - added by Ben 17 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 17 years ago by Ben

www.google.com sets a cookie looking like:
PREF=ID=492500465b386602:CR=1:TM=1060385717:LM=1060385717:S=ObwkB-ygcqpb_pSq
Where PREF is the Name and the rest is the value

It makes fail the code in web.py line 173 which does a:
k, v = cook.split('=')
as split('=') returns more than two values we get a
ValueError: unpack list of wrong size
Probable fix should be:
k, v = cook.split('=', 1)

Maybe rest of twisted should also be "secured" in this way
when a split returns directly into variables.

comment:2 Changed 17 years ago by Ben

Again for 1.0.7alpha4. Forgot to precise it before.

Changed 17 years ago by Ben

Attachment: patch_request.diff-u added

comment:3 Changed 17 years ago by Ben

Patch for teh cook.split('=', 1) suggested in the
description of the bug 

AND

small mechanism to allow the users of HTTPClientFactory to
get the status given by the server.

Patch done with 
diff -u
against the CVS freshly checked out.

comment:4 Changed 17 years ago by Ben

radix said he would have a look at it

comment:5 Changed 17 years ago by Ben

and assigning to radix is also not a bad idea.. :)

comment:6 Changed 17 years ago by radix

ok, i've cleaned this up, added tests, docstrings, and have
committed.

comment:7 Changed 9 years ago by <automation>

Owner: radix deleted
Note: See TracTickets for help on using tickets.