Opened 16 years ago

Closed 14 years ago

#1890 enhancement closed fixed (fixed)

move examples from core into correct sub-packages

Reported by: itamarst Owned by:
Priority: low Milestone:
Component: core Keywords:
Cc: Thijs Triemstra Branch: branches/subproject-examples-1890
branch-diff, diff-cov, branch-cov, buildbot
Author: exarkun

Description

e.g. pairudp.py is now in core but ought to be in pair.

Attachments (1)

sub-examples-1890.patch (1.9 KB) - added by collab 14 years ago.
patch against r24208

Download all attachments as: .zip

Change History (13)

comment:1 Changed 14 years ago by collab

Cc: collab added
Owner: changed from Glyph to collab
Status: newassigned

Changed 14 years ago by collab

Attachment: sub-examples-1890.patch added

patch against r24208

comment:2 Changed 14 years ago by collab

Keywords: review added
Owner: collab deleted
Status: assignednew

pairudp.py is the most obvious one that should me moved but not sure if there are any others, maybe the cursesclient.py which uses words (although it's a GUI app)? Attached a patch for pairudp.py (for some reason svn diff doesn't properly move the file to the new folder, at least thats what the diff shows, hope this works for you).

comment:3 Changed 14 years ago by Jean-Paul Calderone

Keywords: review removed
Owner: set to collab

cursesclient.py should probably change somehow. It's supposed to be an example of doing curses with Twisted - maybe it should use something from twisted core to do this, instead of being an IRC client?

It could be a memcache client or an ident client or an ftp client or probably one of a few other things. It could also completely avoid doing networking and just do some Twistedy stuff with, say, callLater. Feel like trying to make this change? We could also keep the current cursesclient.py in doc/words/examples, since I guess more examples is generally better than fewer examples.

For the pairdudp.py change, I assume you just did svn mv doc/core/examples/pairudp.py doc/pair/examples/? You're right that svn diff doesn't properly reflect moves (and patch doesn't apply the attached diff very well, but I can just do the svn mv manually).

comment:4 in reply to:  3 Changed 14 years ago by collab

Owner: changed from collab to Jean-Paul Calderone

Replying to exarkun:

We could also keep the current cursesclient.py in doc/words/examples, since I guess more examples is generally better than fewer examples.

I'd vote for moving it to doc/words/examples and giving it a simple description in the docs.

For the pairdudp.py change, I assume you just did svn mv doc/core/examples/pairudp.py doc/pair/examples/? You're right that svn diff doesn't properly reflect moves (and patch doesn't apply the attached diff very well, but I can just do the svn mv manually).

Yeah, in that case it's that incorrect svn diff behavior. I'm probably not able to come up with a better description for that curses client than you can, so assigning it back to you so we can close this ticket after a few simple moves, cause it's been open for more then years ;)

comment:5 Changed 14 years ago by Thijs Triemstra

Cc: Thijs Triemstra added; collab removed

comment:6 Changed 14 years ago by Jean-Paul Calderone

author: exarkun
Branch: branches/subproject-examples-1890

(In [24283]) Branching to 'subproject-examples-1890'

comment:7 Changed 14 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

Stuff moved, indexes updated. I'm curious about the comment above, "and giving it a simple description in the docs". Which docs would benefit from a description?

comment:8 in reply to:  7 Changed 14 years ago by Thijs Triemstra

Keywords: review removed
Owner: set to Jean-Paul Calderone

Replying to exarkun:

Stuff moved, indexes updated. I'm curious about the comment above, "and giving it a simple description in the docs". Which docs would benefit from a description?

The example listings in the .xhtml docs sometimes have a description like this one :

  • echoserv.py - simplest possible TCP server
  • echoserv_udp.py - simplest possible UDP server
  • echoserv_ssl.py - simple SSL server
  • echoclient.py - simple TCP client
  • echoclient_udp.py - simple UDP client

Would be good to have such a one-liner for every example where possible.

comment:9 Changed 14 years ago by Jean-Paul Calderone

Keywords: review added
Owner: Jean-Paul Calderone deleted

Okay, added

comment:10 Changed 14 years ago by Thijs Triemstra

Keywords: review removed
Owner: set to Jean-Paul Calderone

I'd say merge.

comment:11 Changed 14 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [24628]) Merge subproject-examples-1890

Author: exarkun Reviewer: thijs Fixes: #1890

Move two subproject examples out of core into their respective subprojects.

comment:12 Changed 11 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.