trial pyunit support mixes up argument order when creating Failures

[Jean-Paul Calderone]

pyunit does this:

result.addError(self, self.__exc_info())

which trial translates into

    def addError(self, test, error):
        """Report an error that occurred while running the given test.

        @type test: L{pyunit.TestCase}
        @type fail: L{failure.Failure} or L{tuple}
        """
        if isinstance(error, tuple):
            error = failure.Failure(*error)
        self.errors.append((test, error))

but Failure.init is defined like

    def __init__(self, exc_value=None, exc_type=None, exc_tb=None):

exc_value and exc_type are flipped.

[Jonathan Lange]

Well spotted!

[Jonathan Lange]

source:branches/exception-order-1855

Thanks.

[Jonathan Lange]

(In [17376]) Fix TestResult to correctly handle errors in pyunit TestCases

• Author: jml
• Review: exarkun
• Fixes #1855

addError and addFailure were naively passing the exc_info tuple straight to the Failure constructor. I've added tests which demonstrate the problem and fixed addError and addFailure to flip the order of the tuple.

[hawkowl]

[mass edit] Removing review from closed tickets.