Opened 13 years ago

Closed 11 years ago

#1806 defect closed fixed (fixed)

adbapi.ConnectionPool.noisy defaults to True, when it should be False

Reported by: moof Owned by: moof
Priority: highest Milestone:
Component: core Keywords:
Cc: therve Branch:

Description (last modified by Jean-Paul Calderone)

The documentation for adbapi.ConnectionPool.__init__ claims cp_noisy defaults to False, when it actually defaults to True.

It should default to false, as defaulting to True is a security risk: it prints the user name and password used to connect to the db in the log.

Attachments (1)

adbapi.patch (545 bytes) - added by moof 13 years ago.
Patch to set the default to False

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by moof

Attachment: adbapi.patch added

Patch to set the default to False

comment:1 Changed 13 years ago by moof

Type: enhancementdefect

comment:2 Changed 13 years ago by therve

Cc: therve added
Owner: changed from Glyph to moof
Priority: normalhighest

Let's say I reviewed it :).

comment:3 Changed 13 years ago by Jean-Paul Calderone

Description: modified (diff)

comment:4 Changed 11 years ago by therve

Resolution: fixed
Status: newclosed

(In [23460]) aChange default value of t.e.adbapi.ConnectionPool.noisy to False, as documented and expected. This also removes a security risk as username and password were printed in the logs.

Author: moof Reviewer: therve Fixes #1806

Note: See TracTickets for help on using tickets.