Opened 13 years ago

Last modified 10 years ago

#1685 defect new

[patch] unicode fixups in words.irc and words.service

Reported by: Yury Yurevich Owned by:
Priority: normal Milestone:
Component: words Keywords: words service irc unicode
Cc: Thijs Triemstra Branch:
Author:

Description

Fixups for unicode in words.irc and words.service. Checked in utf-8 and koi8-r with cyrillic chars.

Also include some cleanups for string (from string module functions to string methods) and type (from type.* to isinstance).

Attachments (1)

words_irc_unicode.patch (32.2 KB) - added by Yury Yurevich 13 years ago.
unicode patch for words.irc and words.service

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by Yury Yurevich

Attachment: words_irc_unicode.patch added

unicode patch for words.irc and words.service

comment:1 Changed 13 years ago by Yury Yurevich

BTW, it alsow needs this changes in cred.checkers:

--- checkers.py.trunk   2006-04-30 23:57:33.000000000 +0700                     
+++ checkers.py 2006-04-30 23:59:30.688426500 +0700                             
@@ -89,11 +89,10 @@                                                             
             return defer.maybeDeferred(                                        
                 credentials.checkPassword,                                     
                 self.users[credentials.username]).addCallback(                 
-                self._cbPasswordMatch, str(credentials.username))              
+                self._cbPasswordMatch, credentials.username)                   
         else:                                                                  
             return defer.fail(error.UnauthorizedLogin())                       
                                                                                
-                                                                               
 class FilePasswordDB:                                                          
     """A file-based, text-based username/password database.

comment:2 Changed 13 years ago by Jonathan Lange

Thanks for the patch j2a. We'd really appreciate it if you could also provide some unit tests for your patch. We need tests from someone before we can apply your patch to trunk.

comment:3 Changed 10 years ago by Thijs Triemstra

Cc: Thijs Triemstra added

comment:4 Changed 8 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.