Opened 16 years ago
Closed 16 years ago
#1668 enhancement closed fixed (fixed)
Update release automation to work with recent version changes
Reported by: | radix | Owned by: | |
---|---|---|---|
Priority: | highest | Milestone: | |
Component: | core | Keywords: | |
Cc: | Branch: | ||
Author: |
Description
For example, admin/change-versions.
Change History (10)
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
The first poin is fixed and the second point I'm ignoring : trunk will just contain README files with the "replace-me" tags instead of actual version numbers. Real version numbers will still be available in python code.
comment:3 Changed 16 years ago by
Owner: | changed from Glyph to radix |
---|---|
Status: | new → assigned |
Sorry, I don't know how this got assigned to glyph.
comment:4 Changed 16 years ago by
Keywords: | review added |
---|
review! source:/branches/release-versioning-1668.
comment:5 Changed 16 years ago by
Status: | assigned → new |
---|
- twisted/python/dist.py - getVersion should have a docstring
- admin/change-versions
- most of this code should be in twisted/python/ somewhere (dist.py, I guess). The script should import main from there and call it and not much else.
- loadVersionFrom should have a unit test and docstring
- replaceProjectVersion should have a unit test and a docstring
comment:6 Changed 16 years ago by
Keywords: | review removed |
---|
comment:7 Changed 16 years ago by
Keywords: | review added |
---|---|
Owner: | changed from radix to Jean-Paul Calderone |
all issues addressed. Please re-review.
comment:8 Changed 16 years ago by
Owner: | changed from Jean-Paul Calderone to radix |
---|
There are still a couple occurances of "twisted"
in getVersion that should be base
instead.
verstringMatcher should use a raw string, even though r"\." == "\."
Add whitespace around assignments near the end of inputNewVersion
Everything else looks cool.
comment:9 Changed 16 years ago by
Keywords: | review removed |
---|---|
Resolution: | → fixed |
Status: | new → closed |
I've fixed these issues and merged in r16792.
comment:10 Changed 11 years ago by
Owner: | radix deleted |
---|
Ok, work has started in release-versioning-1668. I've gotten rid of the redundancy of version in setup.py files, by moving version specification into _version.py files in each project directory.
Things left to do: