Opened 16 years ago

Closed 16 years ago

#1602 enhancement closed fixed (fixed)

smtp.SMTP would be faster using LineOnlyReceiver

Reported by: nickm Owned by:
Priority: normal Milestone:
Component: mail Keywords:
Cc: Branch:
Author:

Description

I tried to write a load generator for $PRODUCT, and found that smtp.SMTP was too slow, but that I could improve the performance by over 3x (which was enough to stress the $PRODUCT) by switching smtp.SMTP's dataReceived() with one close to LineReceiver's. Is there anything keeping this from going into the mainline?

Attachments (1)

ticket1602.diff (828 bytes) - added by PenguinOfDoom 16 years ago.

Download all attachments as: .zip

Change History (4)

Changed 16 years ago by PenguinOfDoom

Attachment: ticket1602.diff added

comment:1 Changed 16 years ago by PenguinOfDoom

Tests pass with the attached patch. Does Divmod use smtp.SMTP.rawDataReceived for something?

comment:2 Changed 16 years ago by Jean-Paul Calderone

Resolution: fixed
Status: newclosed

(In [16457]) Change t.mail.smtp.SMTP to use LineOnlyReceiver instead of LineReceiver

Author: exarkun Reviewer: itamarst Fixes #1602

SMTP is a purely line-oriented protocol. The existing code never places SMTP into raw-mode, and there is no good reason for anyone to ever do this. Delete rawDataReceived and change the base class to the faster LineOnlyReceiver.

comment:3 Changed 11 years ago by <automation>

Owner: Jean-Paul Calderone deleted
Note: See TracTickets for help on using tickets.