Opened 13 years ago

Closed 8 years ago

#1587 defect closed wontfix (wontfix)

web2 DirectoryLister is too inefficient!

Reported by: Jean-Paul Calderone Owned by:
Priority: normal Milestone:
Component: web2 Keywords:
Cc: Wilfredo Sánchez Vega, oubiwann Branch:
Author:

Description

It builds up a response by repeated string concatenation.

StringIO or list, please.

Change History (8)

comment:1 Changed 13 years ago by jknight

Building up a string with s += 'foo' is actually faster in modern pythons. However, I don't disagree that it's poor style, so if you'd like to fix it, (and #1578 at the same time perhaps), that'd be fine with me.

comment:2 Changed 13 years ago by Jean-Paul Calderone

#1578? I'm guessing that's not really the ticket you meant.

comment:3 Changed 13 years ago by jknight

#1576, sorry.

comment:4 Changed 13 years ago by Wilfredo Sánchez Vega

Cc: Wilfredo Sánchez Vega added

comment:5 Changed 13 years ago by Wilfredo Sánchez Vega

There appears to be a branch called web2-DirectoryLister-1587, which is presumably related to this bug.

comment:6 Changed 13 years ago by oubiwann

Cc: oubiwann added

comment:7 Changed 9 years ago by <automation>

Owner: jknight deleted

comment:8 Changed 8 years ago by washort

Resolution: wontfix
Status: newclosed
Note: See TracTickets for help on using tickets.