Opened 15 years ago

Last modified 15 years ago

#1165 defect closed fixed (fixed)

[PATCH] Correct recipients type information in IMessageDelivery.receivedHeader docstring

Reported by: pacopablo Owned by:
Priority: high Milestone:
Component: mail Keywords: documentation
Cc: Jean-Paul Calderone, pacopablo Branch:
Author:

Description


Attachments (1)

IMessageDelivery.patch (551 bytes) - added by pacopablo 15 years ago.

Download all attachments as: .zip

Change History (4)

Changed 15 years ago by pacopablo

Attachment: IMessageDelivery.patch added

comment:1 Changed 15 years ago by pacopablo

In twisted/mail/smtp.py the docstring for receivedHeader states that recipients
is a "C{list} of C{str}"

However, it appears that it is actually a list of User objects.  The relevent
code from SMTP.do_RCPT is:

rcvdhdr = self.delivery.receivedHeader(
    helo, origin, [u for (u, f) in recipients])

where:

recipients = self._to

and:

self._to.append((user, to))

set in SMTP._cbToValidate


patch -p1 from the root of the TwistedMail-0.1.0 tarball.

comment:2 Changed 15 years ago by Jean-Paul Calderone

Fixed in r14424

comment:3 Changed 10 years ago by <automation>

Note: See TracTickets for help on using tickets.