Opened 16 years ago

Closed 16 years ago

#1127 defect closed fixed (fixed)

web2 file upload and unit test problems

Reported by: Jean-Paul Calderone Owned by:
Priority: high Milestone:
Component: web Keywords:
Cc: Jean-Paul Calderone, David Reid Branch:
Author:

Description


Change History (5)

comment:1 Changed 16 years ago by Jean-Paul Calderone

[20:43] <exarkun> dreid: r14141 should be using os.open() with the mode
parameter to avoid allowing arbitrary parties to open the file between when it
is created and when the chmod runs
[20:43] <exarkun> dreid: and TestCase has a mktemp() method
[20:43] <exarkun> dreid: and arguably, deleting the temporary data after the
test finishes is wrong, since it makes understanding why the test breaks, when
it breaks, that much harder

comment:2 Changed 16 years ago by David Reid

I've made the first two changes addressed. If there is a good way to only do
something if all tests succeed I'd be happy to not delete the files under the
circumstances of failing tests.

comment:3 Changed 16 years ago by David Reid

I believe these problems were addressed, are there other related problems or can I 
close this bug?

comment:4 Changed 16 years ago by David Reid

Resolution: fixed
Status: newclosed

comment:5 Changed 11 years ago by <automation>

Owner: David Reid deleted
Note: See TracTickets for help on using tickets.