#1074 defect closed fixed (fixed)
domish.Element checking __class__, breaks inheritance
Reported by: | VislabSteve | Owned by: | |
---|---|---|---|
Priority: | highest | Milestone: | Words-0.4 |
Component: | words | Keywords: | |
Cc: | ralphm, VislabSteve | Branch: | |
Author: |
Description
Change History (12)
comment:2 Changed 13 years ago by
Confirmed. It would be even better if we worked with interfaces here, so that we can avoid the isinstance horrors. I'll look into this.
comment:3 Changed 12 years ago by
Component: | → words |
---|---|
Keywords: | words removed |
Milestone: | → Twisted 2.3 |
Priority: | high → normal |
Status: | new → assigned |
source:branches/domish-namespaces-1444-2 adds a domish.IElement to remedy this. When that branch has been merged I'll review the rest of the code to use it.
comment:4 Changed 12 years ago by
Keywords: | review added |
---|---|
Status: | assigned → new |
As #1444 has been solved, all that remained was replacing isinstance calls. Created source:branches/xish-IElement-1074 and did that.
comment:5 Changed 12 years ago by
Priority: | normal → highest |
---|
comment:6 Changed 12 years ago by
Owner: | ralphm deleted |
---|
comment:7 Changed 12 years ago by
Owner: | set to warner |
---|---|
Status: | new → assigned |
comment:8 Changed 12 years ago by
Keywords: | review removed |
---|---|
Owner: | changed from warner to ralphm |
Status: | assigned → new |
looks good to me, handing back to ralphm for committing
comment:9 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:10 Changed 12 years ago by
Milestone: | Twisted-2.3 → Twisted-2.4 |
---|
Milestone Twisted-2.3 deleted
comment:11 Changed 12 years ago by
Milestone: | Twisted-2.4 → Words-0.4 |
---|
comment:12 Changed 7 years ago by
Owner: | ralphm deleted |
---|
Note: See
TracTickets for help on using
tickets.