Opened 17 years ago

Last modified 17 years ago

#1011 defect closed fixed (fixed)

[PATCH] Missing return in HTTPPageGetter.handleStatus_301()?

Reported by: jojo Owned by:
Priority: high Milestone:
Component: web Keywords:
Cc: Jean-Paul Calderone, jknight, jojo Branch:
Author:

Description


Change History (4)

comment:1 Changed 17 years ago by jojo

I think there is a return missing in the handleStatus_301() method of
web.client.HTTPPageGetter (line 84 in svn-version):

  l = self.headers.get('location')
  if not l:
      self.handleStatusDefault()
+     return
  url = l[0]

Without a "return" the following line will raise a TypeError.

comment:2 Changed 17 years ago by jojo

BTW: On Linux this is just annoying because of the resulting traceback being
printed. On Windows XP Python.exe crashes because of this (don't know exactly why)!

comment:3 Changed 17 years ago by jknight

Applied in r13863.

comment:4 Changed 11 years ago by <automation>

Owner: jknight deleted
Note: See TracTickets for help on using tickets.