[Twisted-web] Possible bug in nevow.testutil.FakeRequest setHeaders and getHeaders

[Peter Westlake]

On Tue, 28 Sep 2010 17:52 +0000, exarkun at twistedmatrix.com wrote:
...
> It's correct that setHeader and getHeader operate on different data 
> sets.  Less confusing names for what the two methods do would have been 
> setResponseHeader and getRequestHeader respectively.
> 
> In newer versions of Twisted, the requests have two new attributes, 
> requestHeaders and responseHeaders, with various methods for inspection 
> and modification.  Nevow's Request class should inherit these.  However 
> Nevow's FakeRequest probably doesn't.
> 
> The right way to test for headers is probably to fix the FakeRequest 
> class so that it is more inspectable, and to verify that it actually 
> behaves in the same way as a real request object.

Thanks for the explanation! I've done this for now:

  class FakeRequest(nevow.testutil.FakeRequest):
      def getResponseHeader(self, key):
          return self.headers.get(key.lower())

Should I put in a ticket requesting something like this?

Peter.