[Twisted-web] [PATCH] Are we ready for a Page.remember fix?

Matt Goodall matt at pollenation.net
Tue Nov 23 08:57:08 MST 2004

> On Nov 23, 2004, at 3:37 AM, Matt Goodall wrote:
>>> So, are there any objections to Page.remember()? Even if it's not an
>>> elegant
>>> solution, it works for me, and it's generic enough that I think it's
>>> worth
>>> keeping.
>> For some reason I've never liked Page.remember() even though I would
>> probably use it if it existed (and worked properly).
>> So, a reluctant +1 from me.
>> There's one problem with the patch - once the PageContext has been
>> created
>> Page.remember() doesn't do anything. The Page *used* to have a context
>> set
>> via a property but that's been gone for a while now. Any ideas how to
>> fix
>> that?
> If this is the only thing you don't like about it, I think it's a
> documentation issue.

Yep, exactly. The problem/limitation with the patch is just that and has
nothing to do with what I think about Page.remember.

As I said in my previous message, it's more an issue of the method name
and docstring. If you think changing just the docstring is sufficient then
I'm fine with that.

Cheers, Matt

More information about the Twisted-web mailing list