[Twisted-web] Add fromContext to nevow.url and add a warning to fromRequest

Donovan Preston dp at ulaluma.com
Tue Nov 9 09:02:40 MST 2004


On Nov 9, 2004, at 4:20 AM, Matt Goodall wrote:

> Hi,
>
> I've mentioned this issue but I find some of the nevow.url module
> non-obvious mostly because of naming. fromRequest is one of the methods
> I dislike because its name implies (to me, at least) that it will build
> a URI that matches the request but it actually uses the prepath.
>
> Attached is an initial patch (i.e. not tested) that adds a fromContext
> class method and displays a warning for fromRequest. My intention is to
> change fromRequest sometime in the future so it builds a URL from
> request.uri.
>
> What do you all think of this change?

+1

dp




More information about the Twisted-web mailing list