[Twisted-Python] Twisted trunk and klein?

Wilfredo Sánchez Vega wsanchez at wsanchez.net
Thu Feb 11 12:25:35 MST 2021


On Feb 10, 2021, at 3:44 PM, Glyph <glyph at twistedmatrix.com> wrote:
> 
> This isn't even a bug in Klein, it's an issue with a version pin in its tox.ini:  https://github.com/twisted/klein/blob/6e7b37158dea2fe73180809803a872ed98143c6d/tox.ini#L36 <https://github.com/twisted/klein/blob/6e7b37158dea2fe73180809803a872ed98143c6d/tox.ini#L36> 
> 
> The constraints from requests (<3,>=2.5) and hyperlink (>=2.5) are perfectly compatible; one's just a subset of the other.

  Sure, they are compatible, but Klein doesn’t use requests directly, and this only looks to be failing in trunk.

  My concern here is that Twisted may have added a dependency on requests, and that dependency means that if you want IDNA==3.1, as Klein’s tox.ini does, that you aren’t allowed to.  That seems weak; I’d say a bug.  No?

	-wsv

-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20210211/fec8b168/attachment.htm>


More information about the Twisted-Python mailing list