[Twisted-Python] Question about FileDescriptor.loseConnection() signature found by mypy

[Craig Rodrigues]

twisted.internet.abstract.FileDescriptor.loseConnection() was changed here
in 2004:
https://github.com/twisted/twisted/commit/081d393ab03da92d744d8fb2b5d77705662a0caa

This change was done so long ago, but I think changing the signature like
that was wrong.

I took a guess at how to fix this and submitted this:

https://github.com/twisted/twisted/pull/1292

--
Craig


On Tue, Jun 16, 2020 at 1:52 AM Glyph <glyph at twistedmatrix.com> wrote:

>
>
> > On Jun 15, 2020, at 8:43 PM, Craig Rodrigues <rodrigc at crodrigues.org>
> wrote:
> >
> > In twisted.internet.abstract.FileDescriptor.loseConnection, the
> loseConnection method
> > is defined like:
> >
> >     def loseConnection(self,
> _connDone=failure.Failure(main.CONNECTION_DONE)):
>
> I think this signature might just be... wrong?  ITransport doesn't include
> it.  Does anything actually use this argument?
>
> -g
>
>
> _______________________________________________
> Twisted-Python mailing list
> Twisted-Python at twistedmatrix.com
> https://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20200616/8afe07e1/attachment.htm>