[Twisted-Python] Backward incompatible fixes to backward incompatible changes

Jean-Paul Calderone exarkun at twistedmatrix.com
Thu Apr 25 10:52:14 MDT 2019


Hello all,

I'd like to discuss the project policy/process for dealing with incorrect
backward incompatibilities that end up released.

As a case study, we could look at https://twistedmatrix.com/trac/ticket/9410
<https://twistedmatrix.com/trac/ticket/9410#comment:17> /
https://github.com/twisted/twisted/pull/1106

In Twisted 16.3.0 the behavior of Request.write was changed so that it
raises an AttributeError if called after the connection has closed.  Prior
to that release, it silently did nothing in that case.

Now, three years later, we have a PR which proposed restoring the behavior
of silently ignoring the write to a closed connection.

The original change was incompatible.  The new change is incompatible.
What should win out?

Jean-Paul
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20190425/322ff161/attachment.html>


More information about the Twisted-Python mailing list