[Twisted-Python] Defining the review workflow on top of GitHub PR

Glyph glyph at twistedmatrix.com
Mon Oct 2 17:09:45 MDT 2017



> On Oct 2, 2017, at 2:48 AM, Adi Roiban <adi at roiban.ro> wrote:
> 
> On 1 October 2017 at 20:09, Glyph <glyph at twistedmatrix.com> wrote:
>> On Oct 1, 2017, at 12:06 PM, Craig Rodrigues <rodrigc at crodrigues.org> wrote:
>> 
>> 
>> Rather than write a bot specific to Twisted, why not just adapt the Twisted
>> project to use a bot written by another project?
>> 
>> 
>> Personally I don't care either way :-).  I was just describing my
>> understanding of the existing plan, not endorsing it.  Hopefully someone
>> more directly involved will comment.
> 
> I expect that in order to make this happen, we will need a transition
> period in which the current system should continue to work, that is
> automatically set/remove "review" keyword to Trac.
> In this way, the new way(tm) can be implemented in various ways (and
> experiment with different ways) and nobody should complain as the old
> system will just work.
> 
> For my project, I am using Klein as the hooks server, but it is based
> on Trac XML-RPC, so I don't think it can be used for Twisted.
> 
> ---------------
> 
> With that in mind, I think that txghbot or something based on
> python/twisted is easier.
> We would need to talk with Trac... maybe over PB
> 
> I remember there was a PB based channel for communicating with Trac
> but I can't find where it is defined.
> I see that kenan is using something [1] BOT_PORT = 15243, I can't find
> where a service with that port is started.

The PB interface is unmaintained and pretty much only still exists for IRC notifications (if I remember correctly); the process binding that port is Kenaan (the IRC bot).

https://trac-hacks.org/wiki/XmlRpcPlugin <https://trac-hacks.org/wiki/XmlRpcPlugin> is now a bit of a misnomer as it also supports JSON-RPC as well.  We should probably just check that the plugin is upgraded and use that.

-glyph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20171002/e4416b98/attachment-0002.html>


More information about the Twisted-Python mailing list