[Twisted-Python] Defining the review workflow on top of GitHub PR

Craig Rodrigues rodrigc at crodrigues.org
Sun Oct 1 13:06:41 MDT 2017


On Sat, Sep 30, 2017 at 3:14 PM, Adi Roiban <adi at roiban.ro> wrote:

>
>
> orking on a bot to re-open pull requests when a submitter posts a "please
> review" comment: https://github.com/markrwilliams/txghbot



Rather than write a bot specific to Twisted, why not just adapt the Twisted
project to use a bot written by another project?

For example, the Zulip project has written zulipbot:

https://github.com/zulip/zulipbot#zulipbot

Docs for it are here:

http://zulip.readthedocs.io/en/latest/zulipbot-usage.html

and a presentation for it was given here:

http://opensourcebridge.org/sessions/1992

A lot of the motivations for zulipbot are similar to what the Twisted
project is facing:
https://github.com/zulip/zulipbot/wiki/FAQ

such as giving non-committers the ability to add labels to issues or PR's.

zulipbot is actively used, and you can see it in action in their issues and
PR's:
https://github.com/zulip/zulip/issues?utf8=%E2%9C%93&q=is%3Aissue%20or%20is%3Apull

I've met some of the Zulip developers at Pybay.  They are really focused on
improving developer experience and
onboarding of new developers.  Rather than maintain our own bot, the
Twisted project would probably
get further along with zulipbot, and working with the zulip developers to
fill in any missing gaps on that bot.

--
Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20171001/8132199f/attachment-0002.html>


More information about the Twisted-Python mailing list