[Twisted-Python] Question regarding patch submission

Tristan Seligmann mithrandi at mithrandi.net
Sun Jun 25 22:09:32 MDT 2017


On Mon, 26 Jun 2017 at 05:34 Jason Litzinger <jlitzingerdev at gmail.com>
wrote:

> However, after incorporating review comments in new commits and,
> force-pushing the feature branch, is it expected that the review comments
> may
> be damaged?
>

I think this is expected; this is just an unfortunate shortcoming of GitHub
PR reviews.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20170626/2a7022c5/attachment-0002.html>


More information about the Twisted-Python mailing list