[Twisted-Python] Question regarding patch submission

Jason Litzinger jlitzingerdev at gmail.com
Sun Jun 25 21:34:26 MDT 2017


Hello,
Quick question regarding #15 of
https://twistedmatrix.com/trac/wiki/TwistedDevelopment#SubmittingaPatch.

The step indicates that history shouldn't be re-written and the branch
should be rebased over trunk.  Pretty straightforward, introduce new commits,
don't mess with the old ones.

However, after incorporating review comments in new commits and,
force-pushing the feature branch, is it expected that the review comments may
be damaged?

An example is:
 https://github.com/twisted/twisted/pull/793

The review comment on May 25 leads to nowhere because that file appeared in
trunk and was dropped when it was rebased.  Not the end of the world, but might
make reviewing the history on subsequent iterations of the PR a little strange.

Thanks!
-Jason Litzinger



More information about the Twisted-Python mailing list