[Twisted-Python] 'ok to merge' label in github?

Glyph glyph at twistedmatrix.com
Mon Jul 3 06:08:07 MDT 2017


Unfortunately, our CI runs can be quite lengthy.  When doing a quick code review, it can often be quite demoralizing to see an hour or two worth of appveyor backlog that needs to run before a ticket can be merged.

I have been thinking about adding a specific "OK to merge" label to PRs that indicates that they've been submitted to pr_as_branch, they've been reviewed, and if the CI results or positive they should be merged, so that someone other than the reviewer might come along and do the actual merge later.  Does anyone else think this would be a good idea?

(I know that there are ways that bots can facilitate this, and if someone else would like to set that up, that would be great.)

-g


More information about the Twisted-Python mailing list