[Twisted-Python] overview: new review queue venue
Amber "Hawkie" Brown
hawkowl at atleastfornow.net
Sun May 22 22:58:56 MDT 2016
Mark has been working on a bot which would reopen it with a comment: https://github.com/markrwilliams/txghbot
- Amber
> On 23 May 2016, at 12:56, Craig Rodrigues <rodrigc at crodrigues.org> wrote:
>
> I submitted this PR, which is now closed: https://github.com/twisted/twisted/pull/62
>
> I don't want to re-open that PR, but I am using that as an example
> As an example, if I wanted to re-open that, how would I go about doing it?
>
> I am not an administrator of the Twisted GitHub project, so on that web link,
> there is no option for me to re-open the PR.
>
> Are you suggesting that I would need to
> -> create a new branch in my repo with new commits
> -> create a new pull request
>
> ?
>
> --
> Craig
>
> On Sun, May 22, 2016 at 9:39 PM, meejah <meejah at meejah.ca> wrote:
>
> closing a PR with a nice note explaining, "please re-open when X is
> fixed/changed" scares away a potential contributer I have my doubts as
> to whether they would fix X if you *didn't* close it...)
>
> _______________________________________________
> Twisted-Python mailing list
> Twisted-Python at twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: </pipermail/twisted-python/attachments/20160523/438b789a/attachment.sig>
More information about the Twisted-Python
mailing list