[Twisted-Python] Spurious commit/ticket links

Glyph Lefkowitz glyph at twistedmatrix.com
Thu Dec 1 12:14:10 MST 2016


> On Dec 1, 2016, at 10:51 AM, Jean-Paul Calderone <exarkun at twistedmatrix.com> wrote:
> 
> Hi,
> 
> In the last couple days I've noticed that there are a bunch of spurious changes being made to tickets in the issue tracker.  These come from commit messages that reference a GitHub PR that happens to match a ticket number in trac.
> 
> For example, https://twistedmatrix.com/trac/ticket/600#comment:11 <https://twistedmatrix.com/trac/ticket/600#comment:11>
> 
> I guess this doesn't really hurt anything ... except it's dumping a constant low level of garbage into the issue tracker and generating some annoying emails (that end up having nothing to do with what the subject suggests).

This is, unfortunately, going to keep happening more frequently as the PR numbers get higher and the corresponding Trac tickets get less sparse.

The way I'd like to address it is to change the format of our commit message to namespace Trac tickets differently; instead of just "#", using a URL, like "Fixes https://tm.tl/1234".  I wouldn't even mind if we just had to use the Trac wiki syntax for this, i.e. "Fixes [ticket:1234]" as long as we could turn off the "#" syntax which Github also uses.

However, this involves surgery within Trac's code, and for me personally, the work required to find the relevant regexes and modify them is worse than continuing to deal with the annoyance.  However, I would very much appreciate it if someone else would take this on :-).

-glyph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20161201/fd10ed02/attachment-0002.html>


More information about the Twisted-Python mailing list