[Twisted-Python] Handling upstream patches

Glyph Lefkowitz glyph at twistedmatrix.com
Mon Oct 19 17:20:17 MDT 2015


> On Oct 19, 2015, at 3:22 AM, Gavin Panella <gavin at gromper.net> wrote:
> 
> On 18 October 2015 at 22:47, Glyph Lefkowitz <glyph at twistedmatrix.com> wrote:
> [...]
>> I'd still prefer that we just accept patches consistently through one
>> mechanism. Forgetting about the license question for a second,
>> although today the review queue happens to be empty (!!!), a patch
>> needs a champion willing to respond to review feedback almost as much
>> as it needs to be written in the first place. If the author doesn't
>> have time to submit it, then it's unlikely they'll have time to
>> respond to feedback and complete the process, which just makes more
>> detritus in our issue tracker.
> 
> I fully agree. We should have pushed this fix into Twisted a long time
> ago. In the release-date-imminent maelstrom we unfortunately forgot
> about it at the time, and only noticed it again while porting MAAS to
> Python 3.
> 
> I have a patch for ticket #7650 ready which I'll put up for review when
> Trac decides that it's not full of spam.

The spam filter has been re-set, and I don't see any items in the monitoring queue.  Did you try to re-submit it recently and get denied?

-glyph






More information about the Twisted-Python mailing list