[Twisted-Python] TLS windows wincertstore

[Glyph]

On May 23, 2015, at 06:53, John Aherne <johnaherne at rocs.co.uk> wrote:
> 
> I see that aranbierbaum has done the work on implementing wincertstore ticket 6371.
> 
> For which I am very grateful. Thank you aron
> 
> However, it seems to be waiting some final touches before it can land.
> 
> I assume that aron is using it for his own purposes so I was wondering whether to take a copy of the patch and check it out. And if it works carry on.
> 
> It would be nice to wait for a final say so on the patch but I assume aron has plenty to do at the moment.
> 
> Maybe someone else has already checked it out and can give some assurance that it works.
> 
> Thanks for any info.

The correct next step here would be for you to take Aron's patch and address the review feedback mentioned on 6371.  It sounds like you want to wait around for the patch to be completed by someone else - if everyone does that, then no patches ever get finished :).

You may be concerned that it's somehow rude to pick up someone else's work and complete it.  It isn't - quite the opposite.  If a patch has gone more than a week without being acted upon, it is almost certainly not going to get any attention unless someone else picks it up.

If you are looking for assurance that it "works" - no, it doesn't.  If it were of sufficient quality to be included within Twisted and be said to "work" to that standard, it would already have been included.

Thanks for your interest, and I hope you'll step up to complete this work!

-glyph