[Twisted-Python] Branch name convention

[Glyph]

> On Mar 22, 2015, at 08:35, Christopher Armstrong <radix at twistedmatrix.com> wrote:
> 
> 
>> On Mar 21, 2015, at 7:10 PM, Glyph <glyph at twistedmatrix.com <mailto:glyph at twistedmatrix.com>> wrote:
>> 
>>> 
>>> On Mar 21, 2015, at 3:45 PM, Adi Roiban <adi at roiban.ro <mailto:adi at roiban.ro>> wrote:
>>> 
>>> On 16 March 2015 at 18:53, Glyph Lefkowitz <glyph at twistedmatrix.com <mailto:glyph at twistedmatrix.com>> wrote:
>>>> 
>>>> On Mar 16, 2015, at 11:20 AM, Adi Roiban <adi at roiban.ro <mailto:adi at roiban.ro>> wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> I would like to ask why the  twisted branch name convention ask for
>>>> trailing ticket ID.
>>>> 
>>>> Why not leading ID?
>>>> 
>>>> some-text-1234 vs 1234-some-text
>>>> 
>>>> -----
>>>> 
>>>> The default git auto completion script only does search at the start
>>>> of the string.
>>>> 
>>>> When I work on a ticket I know the ticket number but I always forget
>>>> the name of the branch... so I have to search it inside the Trac
>>>> ticket.
>>>> 
>>>> It is not a big deal and I know that there are greater annoyances in
>>>> Twisted dev process but I am curios if there is someone else who don't
>>>> like this convention and if there is any chance of changing it.
>>>> 
>>>> 
>>>> When we started this it seemed like the descriptive name would be easier to
>>>> remember than the opaque ticket number.  I agree that was the wrong call,
>>>> oddly enough, I do remember the ticket numbers more.  That said, we can
>>>> switch as soon as all the currently outstanding branches are landed and
>>>> deleted: https://twistedmatrix.com/trac/browser/branches <https://twistedmatrix.com/trac/browser/branches> ;-)
>>> 
>>> Which are the "all currently outstanding branches" ?
>>> 
>>> I see a lot of branched older than 5 years... with 210 branches older
>>> than 2 years :(
>>> 
>>> Why do we need to wait for them?
>> 
>> 
>> Sorry, that was not a very clear comment :).
>> 
>> What I mean is, any change to the naming convention needs to include a plan for addressing the existing branches, so that any automation which relies on the current branch naming format (mostly the post-commit hook) can be updated at the appropriate time.
>> 
>> For what it's worth, many of those branches can be removed.  We used to have a script that automated this deletion, but I can't find it now :-\.
>> 
> 
> It’s probably also possible to just update the automation to support either format so you don’t have to do a big migration or block on an empty branch list.

That would also be fine; the set of old branches is quite finite so we don't need such tooling to be terribly elaborate :).

-g

-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20150322/e3b5bfe9/attachment-0002.html>