[Twisted-Python] Porting twisted.spread.banana to py3

Glyph glyph at twistedmatrix.com
Fri Jul 3 18:25:51 MDT 2015


> On Jul 3, 2015, at 2:00 PM, Jørn Lomax <northlomax at gmail.com> wrote:
> 
> I have found another issue I'm wondering a little how to handle. There are places in the bana_test file that sys.maxint is used. This no longer exists in python3, so how should it be handled. Should we make an artificial maxint to use for python3. I might want to note that it is not used for comparison, but to create an integer over a given size:
> 
> foo = [1, 2, [3, 4], [30.5, 40.2], 5,
>                [b"six", b"seven", [b"eight", 9]], [10],
>                # TODO: currently the C implementation's a bit buggy...
>                sys.maxint * long(3), sys.maxint * long(2), sys.maxint * long(-2)]
> 
> regards,
> Jørn lomax

These tests are just making sure that it's capable of serializing things that don't fit into a machine integer; sys.maxsize should be an acceptable substitute.

-glyph



More information about the Twisted-Python mailing list