[Twisted-Python] INCOMPATIBLE CHANGE: twisted.python.threadpool

[Adi Roiban]

On 26 September 2014 08:43, Glyph <glyph at twistedmatrix.com> wrote:
[snip]

> My inclination would be to expand the thread pool to accommodate these
> usages, but still deprecate these attributes in the next version; but add a
> better "statistics" method that returned an object with "active", "pending",
> and "idle" attributes (all integers).

+1 for statistics method

I am using some of those member for my custom test case
https://github.com/chevah/empirical/blob/master/chevah/empirical/testcase.py#L66
A method which return those integers would be enough for my use case.


----

+1 for reducing the public interface.

With a public adjustPoolsize I prefer to also have read-only
attributes for min / max pool size.
With a public start/stop  a public read-only started attribute might
be useful.... for the case when you don't want to do a  try/catch or
just want to see the state of the pool.

dumpStats could be replaced by a better method dedicated to
statistics, which will return integer instead of using the logger.

`joined` looks like the opposite of started/running... ie, it is redundant.

Regarding `name` attribute, I guess that it might make sense in the
case an application uses multiple thread pools... I have never used
multiple pools so I can not comment on that.

Thanks!

-- 
Adi Roiban