[Twisted-Python] Enabling travis-ci tests for reviews via pull requests

Adi Roiban adi at roiban.ro
Fri Feb 28 08:58:34 MST 2014


Hi,

The possibility of using travis-ci for running tests against patches from
non-commiters was raised during a review so I would like to summarize my
findings.

Travis-CI can run tests on multiple python version and the results are
public.
It will accept any patch submitted via a pull request and will execute the
tests on it.

It only provides Ubuntu 12.04 x64 builders... and with some hacks maybe
also OSX (as used by pyca / cryptography)

I know that Twisted developers don't want to deal with GitHub's pull
requests.
One option is to accept the .travis.yml in trunk, and then each developer
can enable travis-ci build on his/her own fork.

If he/she needs to check a patch, he/she could create a pull request for
his/her own fork of trunk and if Travis-ci is enabled for that fork, a
build is triggers and an email with results is sent.

What do you think? Would you accept such path?

Are there other (better) ways of allowing developers to run tests before
sending a patch?

I think that it is nice to allow developers to run a reference set of tests
before requesting a review.

Thanks!
-- 
Adi Roiban
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://twistedmatrix.com/pipermail/twisted-python/attachments/20140228/8559aaf1/attachment-0001.html>


More information about the Twisted-Python mailing list