[Twisted-Python] positioning framework

[Kasun Thennakoon]

Hi,

It took long time to go through the ticket[1] and understands,
still i couldn't find any issue with it, instead its working perfectly for
me. and thanks to the twisted positioning NMEA adapter, it become easy to
me to write a adapter for the device(MVT380  device[2]) which i'm using in
my project[3].

IMHO,

1. isn't it good to use items() rather than iteritems() since python 3.x
has deprecated iteritems(),

2. In nmea._UNIT_CONVERTERS dictionary mapper, can't see any usage of key
'K' which convert Km/h unit to meters/s because it has a FIXER
for speedInKnots but not for speedInKMh, i think in $GPVTG NMEA string type
(it is not defined in _SENTENCE_CONTENTS) string they use text 'K' to
indicates that speed over ground is in kilometers/hour.

other than those suggestions,its works perfectly well. i wonder why this
positioning module didn't merged with the trunk yet,and i'll be happy if i
can help to get it merged.


[1] https://twistedmatrix.com/trac/ticket/3926
[2] http://www.mvt380.com/
[3]
https://github.com/tmkasun/port/blob/kasun/server_Program/server_twisting/syscall/mvt380.py

-- 
~ Kasun Thennakoon <http://me.knnect.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://twistedmatrix.com/pipermail/twisted-python/attachments/20140212/045af6e8/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: speed_units.patch
Type: text/x-patch
Size: 1273 bytes
Desc: not available
URL: <http://twistedmatrix.com/pipermail/twisted-python/attachments/20140212/045af6e8/attachment.bin>