[Twisted-Python] [Twisted-commits] r31216 - skip glib and gtk reactors in the new test

[exarkun at twistedmatrix.com]

On 12:40 pm, itamar at itamarst.org wrote:
>On Wed, 2011-03-16 at 20:55 -0600, pahan at wolfwood.twistedmatrix.com
>wrote:
>>+
>>+        skippedReactors = ["Glib2Reactor", "Gtk2Reactor"]
>>+        reactorClassName = reactor.__class__.__name__
>>+        if reactorClassName in skippedReactors and 
>>platform.isWindows():
>>+            raise SkipTest(
>>+                "This test is broken on gtk/glib under Windows.")
>>+
>
>Shouldn't that be a todo, rather than a skip? Or maybe file a ticket.

A ticket would be nice, indeed.  We are collecting quite a nice set of 
gtk2-does-not-work-on-Windows issues in our test suite.

Jean-Paul