[Twisted-Python] SURVEY: Have you submitted a patch to Twisted and it never got in?

Jason J. W. Williams jasonjwwilliams at gmail.com
Fri Jul 1 16:01:56 MDT 2011

On Fri, Jul 1, 2011 at 12:59 PM, Itamar Turner-Trauring <itamar at itamarst.org
> wrote:

> > It would be far simpler to setup my DVCS to track JP's remote copy of my
> > ticket's branch...then simply pull from that remote...make my changes and
> > request he pull from me when he's ready to review. Automates the whole
> > process quite a bit and reduces the round trip yak shaving.
> Any reason you can't do this with our git or bzr mirrors?

Because they don't always seem to track the ticket branch folders in a
timely manner. Especially, when JP (he seems to usually be my reviewer :) )
pushes a modification of my patch to the ticket branch. It's at this point
trying to merge in from SVN is usually a nightmare. My Git copy being tied
to an older SVN rev that my patch is based on. SVN just seems to lose it's
brains when my patch isn't in the SVN commit history, because SVN repo
doesn't allow me to commit in. DVCS would allow me to branch, commit to my
repo, and then let JP pull from my repo into his to review and push up to
the Twisted repo when he's happy with it...and all of the commit history is
sane from the original, to my patch to his changes, so when I go to pull
back down from the Twisted repo everything merges sanely.

> Or for that matter, you can include e.g. an github URL in the ticket
> instead of attaching the patch.

Honestly, the "process" documents are pretty clear you're supposed to attach
a patch so that's what I do...also even that wouldn't solve the issue
described above.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20110701/7b4d8bc7/attachment.html>

More information about the Twisted-Python mailing list