[Twisted-Python] HTTPClient handling LF only servers

[Tom Davis]

On Tue, Jan 25, 2011 at 2:23 PM, Kevin Horn <kevin.horn at gmail.com> wrote:

> On Tue, Jan 25, 2011 at 11:54 AM, Jason J. W. Williams <
> jasonjwwilliams at gmail.com> wrote:
>
>> Hi Y'all,
>>
>>
> Howdy, Jason!
>
>
>
>> Certain servers (notably Hacker News) break HTTPClient because they use LF
>> instead of CRLF to terminate header lines. I've uploaded a patch with tests
>> to ticket 4814 (merged into ticket 2842).
>>
>> I'd appreciate a review and some discussion about integrating it.
>>
>> -J
>>
>>
> I'm not really in a position to do a review right now, but since:
>
> 1) 4814 is effectively a duplicate of 2842
> 2) 4814 has a clear problem decription
> 3) 4814 has a patch
> 4) 2842 is old, and confusing


> Can we go ahead and close 2842 in favor of 4814?  We have too many old
> tickets floating around...
>
> (To be clear, I'm not asking Jason to close this ticket...I'm asking for
> the list's opinion)
>

I most certainly agree that 4814 is the more relevant, actionable ticket.
2842 is marred in now-useless history and requires reading through 13
comments just to get to the current point of the ticket as the summary and
description give no indication of it.

4814 is more like a new building constructed on top of 2842's rubble.


>
> Also 3833 is at least similar, if not another duplicate.  It would be nice
> if it could be worked on and/or closed along with this issue.
>

Agreed about 3833. Who cares about finding sites that do/don't send LF? I
could talk about how naively-implemented the whole HN stack is all day, but
it wouldn't get us closer to a resolution for Twisted's web client(s). If
the RFC recommends it for "Tolerant Applications", the only decision is
whether or not we implement that part of the RFC. If it requires more time
to discuss than to actually fix, that means we should probably just fix it
and be done with it.


>
> Kevin Horn
>
> _______________________________________________
> Twisted-Python mailing list
> Twisted-Python at twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://twistedmatrix.com/pipermail/twisted-python/attachments/20110125/5f013f98/attachment.htm