[Twisted-Python] Ldaptor: [PATCH] Reroute errback to deferred returned by search()

Anton Gyllenberg anton at iki.fi
Wed Sep 1 10:45:39 EDT 2010


On Wed, Sep 1, 2010 at 5:05 PM, Anton Gyllenberg <anton at iki.fi> wrote:
> On Wed, Sep 1, 2010 at 4:17 PM, Itamar Turner-Trauring
> <itamar at itamarst.org> wrote:
>> On Wed, 2010-09-01 at 14:52 +0300, Anton Gyllenberg wrote:
>>
>>> Any comments and suggestions welcome!
>>
>> Unit tests are always a good idea :)
>
> That is so true. And if not writing new ones, then at least running
> existing ones. That I hadn't done and it seems I actually broke
> something.

The send_multiResponse() method within the test framework worked
differently and returned None instead of a deferred like the real
version. Making it return defer.Deferred() instead made the tests
pass. I'm new to this trial stuff so need to do some reading before I
dare make test cases for new code.

Thanks!
Anton



More information about the Twisted-Python mailing list