[Twisted-Python] twisted.words.msn broken ?

[Alvin Delagon]

Guys,

MSNP8 has been deprecated at some point in time last July. And the MSN
dispatch server's response to a CVR has been changed causing this
loseConnection in the handle_VER to be called:

def handle_VER(self, params):
        versions = params[1:]
        if versions is None or ' '.join(versions) != MSNP_VER:
            self.transport.loseConnection()
        self.sendCommand('CVR %s %s %s' % (self.nextTID(), MSN_CVR_STR,
self.factory.userHandle))

twisted.words.msn has been written to close the session if the versions
doesn't match. This can be easily fixed correcting MSNP_VER variable
somewhere in the  twisted code (remove MSNP8 the current twisted 8.1 still
works with MSNP9).

I could submit a patch on wednesday after I go back from vacation. :)

Cheers,
Alvin Delagon

On Sat, Aug 23, 2008 at 4:28 AM, Joaquin Keller <joaquin.keller at gmail.com>wrote:

> done.
> maybe is worth moving it to a higher priority since now the whole msn
> code is useless while the fix seems not too hard.
> -- Joaquin
>
> most people ignore it but imvho twisted is the best network framework.
> ever. impressive. thanks.
>
>
> On Fri, Aug 22, 2008 at 6:42 PM, Jean-Paul Calderone <exarkun at divmod.com>
> wrote:
> > On Fri, 22 Aug 2008 18:35:08 +0200, Joaquin Keller
> > <joaquin.keller at gmail.com> wrote:
> >>
> >> Hi all,
> >> when running msn_example.py
> >> I get this:
> >>
> >> 2008/08/22 17:29 +0200 [-] Log opened.
> >> 2008/08/22 17:29 +0200 [-] Starting factory
> >> <twisted.internet.protocol.ClientFactory instance at 0x83d552c>
> >> 2008/08/22 17:29 +0200 [Dispatch,client] Error in line: VER 1 MSNP8
> >> (Invalid version response)
> >> 2008/08/22 17:29 +0200 [Dispatch,client] Stopping factory
> >> <twisted.internet.protocol.ClientFactory instance at 0x83d552c>
> >>
> >> 1 or 2 months ago, it was working perfectly fine.
> >>
> >> I suspect that something has changed on messenger.hotmail.com side
> >>
> >> bonus: this two-week old bug (closed now) seems to be related and
> >> claims to have a solution:
> >> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=493908
> >>
> >>    [...] their response to the CVR command has changed [...]
> >>
> >
> > Can you file a ticket in our issue tracker for this?
> >
> > Jean-Paul
> >
> > _______________________________________________
> > Twisted-Python mailing list
> > Twisted-Python at twistedmatrix.com
> > http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
> >
>
> _______________________________________________
> Twisted-Python mailing list
> Twisted-Python at twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>



-- 
http://www.alvinatorsplayground.blogspot.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/twisted-python/attachments/20080823/aace5138/attachment.html>