[Twisted-Python] Re: glyph changed u'Add a variable in twisted.python.runtime to check for vista'

[Michael Schneider]

Glyph,

I would have no problem with that.  I created the ticket to log the 
issues.  I verified that twisted's runtime code correctly determines that
the current platform is windows.

That is all that I need to work correctly, and it does.

Therve may know of a use case where this would be a problem.  I have none.

Thanks
Mike
trac at twistedmatrix.com wrote:
> Ticket u'Add a variable in twisted.python.runtime to check for vista' changed by glyph <glyph at divmod.com>:
>
> I am sorely tempted to close this as invalid.  Why does anyone ever need to know the difference between XP and Vista using Twisted?  This seems to me like modifying twisted.python.runtime to have different values to check for Ubuntu 6.06 vs. 7.10.  The only consequence I can see is adding a new way for code to ask "is this a windows machine" that will succeed on XP but fail on Vista (or vice versa).  Shouldn't we leave platform detection of this granularity up to the code which will actually care?  i.e. if you are asking if it's Vista because Vista has a new or changed win32 function, shouldn't you be asking the win32 wrapper?
>
>
> If Twisted needs to make this determination for its own purposes, then this makes sense to me.  Is Twisted going to be making different API calls on Vista and XP?  If not, I'd like to consider them the same platform.
>
> ---------
>
> ---------
> http://twistedmatrix.com/trac/ticket/2881
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>