[Twisted-Python] XMLRPC Server: Bug with None response

Jean-Paul Calderone exarkun at divmod.com
Wed Mar 8 11:13:59 EST 2006


On Wed, 08 Mar 2006 15:43:30 +0000, Yvain Malsot <ymalsot at besancon.parkeon.com> wrote:
>Message interesting for the following twisted developpers (@see ticket 
>#1132):
>- oubiwann
>- jknight
>- itarmarst
>
>
>Hi,
>
>as we have seen in our developpment spikes and at this place: 
>http://twistedmatrix.com/pipermail/twisted-web/2005-September/001903.html
>there's a bug when Twisted XML-RPC server deals with 'None' method response.
>
>The previous message has given a patch (seen at the end of message) for 
>using the 'allow_none' parameter in order to resolve bug.
>
>As we are new twisted users and haven't seen any revision for 
>twisted.web.xmlrpc module (since 2 years), we are asking twisted-community 
>the following questions:
>- is this patch acceptable?
>- will it be include in next twisted revision?
>
>We have seen that a new xmlrpc.py is ready to be committed in the web2 
>package (see ticket #1132: http://twistedmatrix.com/trac/ticket/1132) but it 
>doesn't seem to include the previous patch.

Problems with the patch:

  * Doesn't follow the coding standard (allow_none should be allowNone)
  * Includes no unit tests
  * Includes no documentation
  * Isn't in the bug tracker

The feature itself and the implementation otherwise seem reasonable to me.

Jean-Paul




More information about the Twisted-Python mailing list