[Twisted-Python] Re: [Twisted-commits] r15071 - More test cleanup and bug fixes.

Justin Johnson justinjohnson at gmail.com
Wed Nov 9 10:05:19 EST 2005


Fixed. Thanks.

On 11/8/05, Jean-Paul Calderone <exarkun at divmod.com> wrote:
>
> On Tue, 08 Nov 2005 14:30:26 -0700, Justin Johnson
> >Modified: branches/justinj/issue1008/twisted/web/test/test_cgi.py
>
> >==============================================================================
> >--- branches/justinj/issue1008/twisted/web/test/test_cgi.py (original)
> >+++ branches/justinj/issue1008/twisted/web/test/test_cgi.py Tue Nov 8
> 14:30:26 2005
> >@@ -40,6 +40,11 @@
> > print "readallinput ok"
> > '''
> >
> >+if sys.platform.startswith('win'):
> >+ EOL = '\r\n'
> >+else:
> >+ EOL = '\n'
> >+
>
> twisted.python.runtime.platform is better thing to check, here. But rather
> than checking the platform type, how about using os.linesep?
>
> Jean-Paul
>
> _______________________________________________
> Twisted-Python mailing list
> Twisted-Python at twistedmatrix.com
> http://twistedmatrix.com/cgi-bin/mailman/listinfo/twisted-python
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://twistedmatrix.com/pipermail/twisted-python/attachments/20051109/92288f53/attachment.htm 


More information about the Twisted-Python mailing list