[Twisted-Python] Re: [Twisted-commits] r13334 - Make log.err and log.msg actually threadsafe, by executing them in the

Jp Calderone exarkun at divmod.com
Wed Mar 30 08:14:31 EST 2005


On Wed, 30 Mar 2005 11:55:03 +0200, Thomas Vander Stichele <thomas at apestaart.org> wrote:
>
> > > Make log.err and log.msg actually threadsafe, by executing them in the
> > > reactor-loop if not called from the main thread. 
> > 
> > I talked to glyph about this at some point, and he thought that we
> > shouldn't do this, if you want to make observers thread safe you should
> > do so yourself. I'm not sure I agree with glyph, though.
> 
> If you make them threadsafe by marshalling to the reactor, is correct
> ordering still guaranteed ?
> 
> Thomas
> 

  Calls to log.{msg,err} were already serialized, so I don't think any changes have been made to the order observers will be called with events.

  Another thing about the change, though, is that it makes Twisted even more broken on threadless platforms.  *poke foom*

  Jp




More information about the Twisted-Python mailing list