[Twisted-Python] Fwd: [Twisted-commits] r11032 - Made LineReceiver about 3x as fast, and clarified some of the docstrings.

James Y Knight foom at fuhm.net
Sun Jun 19 20:47:56 EDT 2005

On Jun 19, 2005, at 7:51 PM, James Y Knight wrote:

> Two things about that:
> 1) resumeProducing actually now says:
>     def resumeProducing(self):
>         self.paused = False
>         self.transport.resumeProducing()
>         self.dataReceived('')
> This was changed because of <http://twistedmatrix.com/pipermail/ 
> twisted-python/2005-February/009626.html> also <http:// 
> twistedmatrix.com/bugs/issue899>.
> However, if resumeProducing is allowed to immediately produce data,  
> this is somewhat bogus, as it could reverse the order of the data.  
> In reality, a TCP transport's resumeProducing will not immediately  
> produce data, but I think that's a fragile API to both have  
> resumeProducing immediately produce data, and depend on a call to  
> someone else resumeProducing not immediately producing data. I  
> think there's an issue here.

Actually, there is no even potential for reordering of data --  
dataReceived is called with '', afterall. I'm not quite sure what I  
was thinking when I wrote that...sorry.


More information about the Twisted-Python mailing list