[Twisted-Python] DeferredList.addDeferred behaviour

Andrew Bennetts andrew-twisted at puzzling.org
Wed Feb 18 20:33:46 MST 2004


On Wed, Feb 18, 2004 at 10:19:43PM -0500, Christopher Armstrong wrote:
> Andrew Bennetts wrote:
> 
> >It's not clear to me what the right behaviour here is -- if a DeferredList
> >has some number of Deferreds that have all been called, then of course the
> >DeferredList should be marked as called, too.  But if you then add an
> >uncalled Deferred to it, that sounds like a bug.  
> 
> Similar to d.result, IMO, d.called is an "invite-only attribute", in the 
> words of Glyph. If you want to touch it, don't whine about its 
> semantics. :-)

It probably should be _called, then... if nothing else, the API docs should
point this out.  I might fix that when I update the code to deprecate
addDeferred.

> >Can anyone offer reasons why addDeferred should stay?  Donovan -- CVS says
> >you added it, can you remember why?  Is anyone using it?
> 
> And addDeferred looks like it should really be _addDeferred.

Why not just remove it entirely?  I found Donovan on IRC, his opinion was
"remove it" :)

-Andrew.





More information about the Twisted-Python mailing list