[Twisted-Python] Updated SMTP patch

Jp Calderone exarkun at intarweb.us
Mon May 12 14:39:41 EDT 2003

On Mon, May 12, 2003 at 04:28:50PM +0200, Anders Hammarquist wrote:
> Hi!
> Since things have been happening in the smtp code, and my patch for
> the SMTP client hasn't been applied yet, I thought it was time to
> update it. 

  Thanks, I'll see if I can get it committed in the next day or two.

> About the recent change to validateTo using a defered rather than
> "straight" callbacks, I missed the discussion (if any), but I *strongly*
> feel that validateTo and validateFrom should use the same method,
> and that "failed" addresses should be communicated with failures
> rather than "magic". So I changed it.

  I don't see the behavior as magic.  It seems very analogous to str.find()
returning -1 when nothing is found.  The main reason I chose to avoid
failures here was to avoid the costs associated with them.  None instead of
a username as a callback seems to indicate an invalid address as clearly as
a failure object would.

  In this light, do you still object to the existing approach (assume that
at some point, I *will* get around to documenting just how it works, since
this is code meant to be overridden by users).


A sad spectacle.  If they be inhabited, what a scope for misery 
and folly.  If they be not inhabited, what a waste of space.
                -- Thomas Carlyle, looking at the stars
 up 10 days, 16:39, 9 users, load average: 0.02, 0.05, 0.00
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://twistedmatrix.com/pipermail/twisted-python/attachments/20030512/d50602fb/attachment.pgp 

More information about the Twisted-Python mailing list