[Twisted-Python] Re: [Twisted-commits] yay reactors! -r <submodule-of-twisted.internet>

[Jonathan M. Lange]

On Sun, Jan 05, 2003 at 01:12:51AM -0600, radix CVS wrote:
> Modified files:
> Twisted/admin/runtests 1.18 1.19
> 
> ViewCVS links:
> http://twistedmatrix.com/users/jh.twistd/viewcvs/cgi/viewcvs.cgi/admin/runtests.diff?r1=text&tr1=1.18&r2=text&tr2=1.19&cvsroot=Twisted
> http://twistedmatrix.com/users/jh.twistd/viewcvs/cgi/viewcvs.cgi/twisted/scripts/trial.py.diff?r1=text&tr1=1.4&r2=text&tr2=1.5&cvsroot=Twisted
> 
> Index: Twisted/admin/runtests
> diff -u Twisted/admin/runtests:1.18 Twisted/admin/runtests:1.19
> --- Twisted/admin/runtests:1.18	Sat Jan  4 18:52:28 2003
> +++ Twisted/admin/runtests	Sat Jan  4 23:12:48 2003
> @@ -27,8 +27,8 @@
>  
>  from twisted.scripts import trial
>  
> -if len(sys.argv) == 1:
> -    sys.argv.extend(['-p', 'twisted.test'])
> +# People shouldn't really be passing -p to runtests; it's explicitly for twisted.test
> +sys.argv.extend(['-p', 'twisted.test'])
>  

Although people shouldn't be passing -p to runtests, they can be
expected to pass -m. 

The old behaviour was that 'runtests -m twisted.test.test_stuff' would
only run the tests in the test_stuff module. With this commit, the same
command will run the entire test suite, which sucks.

Can we fix it? 

jml
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: </pipermail/twisted-python/attachments/20030106/8626b923/attachment.sig>